From 791260bab71a1c969b17ff77356a8a5f592fad43 Mon Sep 17 00:00:00 2001 From: Paul Durrant Date: Wed, 22 Mar 2017 12:03:54 +0100 Subject: [PATCH] x86/viridian: get rid of the magic numbers in CPUID leaves 1 and 2 The numbers correspond to ASCII characters so just use appropriate character strings directly. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- xen/arch/x86/hvm/viridian.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c index a71f9281ae..0155c1ff62 100644 --- a/xen/arch/x86/hvm/viridian.c +++ b/xen/arch/x86/hvm/viridian.c @@ -119,14 +119,16 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, switch ( leaf ) { case 0: + /* See section 2.4.1 of the specification */ res->a = 0x40000006; /* Maximum leaf */ - res->b = 0x7263694d; /* Magic numbers */ - res->c = 0x666F736F; - res->d = 0x76482074; + memcpy(&res->b, "Micr", 4); + memcpy(&res->c, "osof", 4); + memcpy(&res->d, "t Hv", 4); break; case 1: - res->a = 0x31237648; /* Version number */ + /* See section 2.4.2 of the specification */ + memcpy(&res->a, "Hv#1", 4); break; case 2: -- 2.30.2